Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2015 09 02 #7

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

2015 09 02 #7

wants to merge 5 commits into from

Conversation

jmcreasman
Copy link

Called 2015 09 02 because of taking advantage of mulligan

@al-the-x
Copy link
Member

al-the-x commented Sep 3, 2015

Another example of a PR that could use a checklist... Distilling that checklist from the assignment will also help you piece apart the assignment and not miss things... in theory.

@al-the-x
Copy link
Member

al-the-x commented Sep 3, 2015

This PR should be from 2015-09-02 (as you've done) into jcreasman:master (your forked master branch). You're requesting a pull into TIY-Durham:master, which is where you forked from.

@@ -4,14 +4,14 @@ var expect = require('chai').expect,
describe("About Expects", function() {
// We shall contemplate truth by testing reality, via spec expectations.
it("should expect true", function() {
expect(FILL_ME_IN).to.be.true; //This should be true
expect(true).to.be.true; //This should be true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about an explanation? Write one beneath the test in code comments...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants